Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for local symbol table append read #760

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

desaikd
Copy link
Contributor

@desaikd desaikd commented Jul 11, 2023

Issue #639

Description of changes:

This PR adds local symbol table append read support for binary and text reader.

List of changes:

  • modifies makeSymbolTable signature to take current LST value which will be used to append symbols to current LST.
  • If the reader finds $ion_symbol_table in the imports then it will perform LST append adding all the symbols to current LST.
  • adds unit tests for LST append read support

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@desaikd desaikd requested a review from zslayton July 11, 2023 19:42
Copy link
Contributor

@tgregg tgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@desaikd desaikd merged commit 14b0bab into amazon-ion:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants